feat(core): devtools config #173
Merged
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
There was a problem hiding this comment.
Pull request overview
This PR introduces a DevTools configuration system to the core package, moving configuration handling from the Vite DevTools package. This enables better type safety by avoiding Vite type overrides and allows proper configuration of the clientAuth setting.
Changes:
- Adds a new
isObjectutility function for type checking - Introduces DevToolsConfig interfaces and a normalization function for handling various config input types
- Exports the new config types and functions from the core package
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/core/src/node/utils.ts | Adds isObject type guard utility function for runtime object detection |
| packages/core/src/node/config.ts | Defines DevToolsConfig interfaces and normalizeDevToolsConfig function to handle config normalization |
| packages/core/src/index.ts | Exports the new config types and functions from the package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
webfansplz
force-pushed
the
feat/devtools-config
branch
from
43464a6 to
c01e3fb
Compare
webfansplz
force-pushed
the
feat/devtools-config
branch
from
c01e3fb to
84f313a
Compare
antfu
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Vite 8 beta.13 ships with Vite DevTools (see: vitejs/vite#21331), this PR moves the config to the core repo for better flexibility. We can now drop the Vite type overrides (see: https://github.com/vitejs/devtools/blob/main/packages/kit/src/types/vite-augment.ts#L5) to fix the
clientAuthconfig setting and typecheck CI. /cc @sapphi-red